Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle one file at a time in local symbolization. #848

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

aalexand
Copy link
Collaborator

This allows only keeping a single objfile open to reduce the amount of consumes memory.

This allows only keeping a single objfile open.
@aalexand aalexand requested review from nolanmar511, blakej11 and s-kanev and removed request for nolanmar511 April 22, 2024 16:15
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 40.35088% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 66.66%. Comparing base (0ed6a68) to head (6b6ff20).
Report is 11 commits behind head on main.

Files Patch % Lines
internal/symbolizer/symbolizer.go 40.35% 24 Missing and 10 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #848      +/-   ##
==========================================
- Coverage   66.86%   66.66%   -0.21%     
==========================================
  Files          44       44              
  Lines        9824     9791      -33     
==========================================
- Hits         6569     6527      -42     
- Misses       2794     2802       +8     
- Partials      461      462       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@blakej11 blakej11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aalexand aalexand merged commit 6d00f21 into google:main Apr 22, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants