Skip to content

Commit

Permalink
pw_presubmit: Store buildbucket ids as strs
Browse files Browse the repository at this point in the history
Bug: b/270154434
Change-Id: Ife8008ede754c39841cde1dfa889e91f8c0d3962
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/130892
Reviewed-by: Ted Pudlik <[email protected]>
Pigweed-Auto-Submit: Rob Mohr <[email protected]>
Commit-Queue: Auto-Submit <[email protected]>
  • Loading branch information
mohrr authored and CQ Bot Account committed Feb 24, 2023
1 parent 8db026a commit d0e2943
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion pw_presubmit/docs.rst
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ following members:

* ``round``: The zero-indexed round number.
* ``builds_from_previous_iteration``: A list of the buildbucket ids from the
previous round, if any.
previous round, if any, encoded as strs.

The ``triggers`` member is a sequence of ``LuciTrigger`` objects, which have the
following members:
Expand Down
8 changes: 4 additions & 4 deletions pw_presubmit/py/pw_presubmit/presubmit.py
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ def __len__(self) -> int:
@dataclasses.dataclass
class LuciPipeline:
round: int
builds_from_previous_iteration: Sequence[int]
builds_from_previous_iteration: Sequence[str]

@staticmethod
def create(
Expand All @@ -239,9 +239,9 @@ def create(

return LuciPipeline(
round=int(pipeline_props['round']),
builds_from_previous_iteration=[
int(x) for x in pipeline_props['builds_from_previous_iteration']
],
builds_from_previous_iteration=list(
pipeline_props['builds_from_previous_iteration']
),
)


Expand Down

0 comments on commit d0e2943

Please sign in to comment.