pw_hdlc: Add fuzz tests

Change-Id: Ifce388d6f62b68a1ba6603758ef646eeeee8aa8c Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/143473 Reviewed-by: Alexei Frolov <[email protected]> Commit-Queue: Aaron Green <[email protected]>
google · May 15, 2023 · bf4c22f · bf4c22f
1 parent adf7465
commit bf4c22f
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 2 deletions.
diff --git a/pw_hdlc/BUILD.bazel b/pw_hdlc/BUILD.bazel
@@ -119,9 +119,9 @@ pw_cc_test(
     srcs = ["decoder_test.cc"],
     deps = [
         ":pw_hdlc",
+        "//pw_fuzzer:fuzztest",
         "//pw_result",
         "//pw_stream",
-        "//pw_unit_test",
     ],
 )
 

diff --git a/pw_hdlc/BUILD.gn b/pw_hdlc/BUILD.gn
@@ -179,7 +179,10 @@ pw_python_action("generate_decoder_test") {
 }
 
 pw_test("decoder_test") {
-  deps = [ ":pw_hdlc" ]
+  deps = [
+    ":pw_hdlc",
+    "$dir_pw_fuzzer:fuzztest",
+  ]
   source_gen_deps = [ ":generate_decoder_test" ]
   sources = [ "decoder_test.cc" ]
 }

diff --git a/pw_hdlc/CMakeLists.txt b/pw_hdlc/CMakeLists.txt
@@ -136,6 +136,7 @@ pw_add_test(pw_hdlc.decoder_test
     decoder_test.cc
   PRIVATE_DEPS
     pw_bytes
+    pw_fuzzer.fuzztest
     pw_hdlc
   GROUPS
     modules

diff --git a/pw_hdlc/decoder_test.cc b/pw_hdlc/decoder_test.cc
@@ -17,6 +17,7 @@
 #include <array>
 #include <cstddef>
 
+#include "fuzztest/fuzztest.h"
 #include "gtest/gtest.h"
 #include "pw_bytes/array.h"
 #include "pw_hdlc/internal/protocol.h"
@@ -25,6 +26,7 @@ namespace pw::hdlc {
 namespace {
 
 using std::byte;
+using namespace fuzztest;
 
 TEST(Frame, Fields) {
   static constexpr auto kFrameData =
@@ -152,5 +154,17 @@ TEST(Decoder, TooLargeForBuffer_DecodesNextFrame) {
   EXPECT_EQ(OkStatus(), decoder.Process(kFlag).status());
 }
 
+void ProcessNeverCrashes(ConstByteSpan data) {
+  DecoderBuffer<1024> decoder;
+  for (byte b : data) {
+    if (decoder.Process(b).status() != Status::Unavailable()) {
+      decoder.Clear();
+    }
+  }
+}
+
+FUZZ_TEST(Decoder, ProcessNeverCrashes)
+    .WithDomains(Arbitrary<std::vector<std::byte>>());
+
 }  // namespace
 }  // namespace pw::hdlc