pw_ide: Disable Bazelisk auto-activation by default

The terminal "activation" process just sends text to the terminal,
ending with `\n\r` to "execute" it. This is fine for launching general
purpose terminals and for non-interactive tasks, but for interactive
tasks this interferes with user input.

Fixes: b/358384211
Change-Id: Ic7a381443f1c7b1989a5f20ed8a8f5cd5684ceb0
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/228493
Lint: Lint 🤖 <[email protected]>
Presubmit-Verified: CQ Bot Account <[email protected]>
Reviewed-by: Keir Mierle <[email protected]>
Reviewed-by: Amit Uttamchandani <[email protected]>
Commit-Queue: Auto-Submit <[email protected]>
Pigweed-Auto-Submit: Chad Norvell <[email protected]>

pw_ide/ts/pigweed-vscode/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Change Log
 
+## [1.3.3]
+
+- The `pigweed.activateBazeliskInNewTerminals` option has been set to a default
+  of `false` because, as currently implemented, this feature interferes with
+  interactive tasks like flashing scripts and `pw_console`.
+
 ## [1.3.2]
 
 - When you manually run `Pigweed: Refresh Compile Commands`, we now show a

pw_ide/ts/pigweed-vscode/package.json

@@ -8,7 +8,7 @@
     "type": "git",
     "url": "https://pigweed.googlesource.com/pigweed/pigweed"
   },
-  "version": "1.3.2",
+  "version": "1.3.3",
   "license": "Apache-2.0",
   "engines": {
     "vscode": "^1.75.0"
@@ -89,7 +89,7 @@
       "properties": {
         "pigweed.activateBazeliskInNewTerminals": {
           "type": "boolean",
-          "default": "true",
+          "default": "false",
           "description": "When enabled, the path to Bazelisk will be added to the integrated terminal when launched"
         },
         "pigweed.codeAnalysisTarget": {

pw_ide/ts/pigweed-vscode/src/settings.ts

@@ -124,7 +124,7 @@ function activateBazeliskInNewTerminals(
   value?: boolean,
 ): boolean | undefined | Thenable<void> {
   const { get, update } = boolSettingFor('activateBazeliskInNewTerminals');
-  if (value === undefined) return get() ?? true;
+  if (value === undefined) return get() ?? false;
   return update(value);
 }