Skip to content

Commit

Permalink
pw_libc: Don't implicitly link against global link_deps
Browse files Browse the repository at this point in the history
This added a lot of extra object files into pw_libc.a which
has `complete_static_lib = true`. This didn't cause any
problems because none of those symbols would have been
extracted from pw_libc.a (and if they were they wouldn't
be extracted later). Regardless, it is better that
pw_libc.a include only libc symbols.

Change-Id: I172b8b77b63e37760fc5d81b7795b2ab5aff42fd
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/150051
Reviewed-by: Petr Hosek <[email protected]>
Reviewed-by: Armando Montanez <[email protected]>
Commit-Queue: Alex Brachet <[email protected]>
  • Loading branch information
abrachet authored and CQ Bot Account committed Sep 29, 2023
1 parent 143d599 commit 8083daa
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions pw_libc/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ if (dir_pw_third_party_llvm_libc != "") {

pw_static_library("pw_libc") {
complete_static_lib = true
add_global_link_deps = false
deps = [
":ctype",
":math",
Expand All @@ -161,6 +162,7 @@ if (dir_pw_third_party_llvm_libc != "") {
}
} else {
pw_static_library("pw_libc") {
add_global_link_deps = false
}

pw_test_group("llvm_libc_tests") {
Expand Down

0 comments on commit 8083daa

Please sign in to comment.