Skip to content

Commit

Permalink
pw_build/cmake: Rename _pw_library_multi_value_args
Browse files Browse the repository at this point in the history
Renames _pw_library_multi_value_args to
_pw_add_library_multi_value_args to directly match pw_add_library.

Change-Id: I462471d533b79ab43fd963b51500b9f42f60bdbb
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/94129
Commit-Queue: Ewout van Bekkum <[email protected]>
Pigweed-Auto-Submit: Ewout van Bekkum <[email protected]>
Commit-Queue: Auto-Submit <[email protected]>
Reviewed-by: Wyatt Hepler <[email protected]>
  • Loading branch information
Ewout van Bekkum authored and CQ Bot Account committed May 11, 2022
1 parent a8b259c commit 32abf81
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions pw_build/pigweed.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,8 @@ function(pw_auto_add_module_tests MODULE)
endforeach()
endfunction(pw_auto_add_module_tests)

# Sets the provided variable to the common library arguments.
macro(_pw_library_multi_value_args variable)
# Sets the provided variable to the multi_value_keywords from pw_add_library.
macro(_pw_add_library_multi_value_args variable)
set("${variable}" SOURCES HEADERS
PUBLIC_DEPS PRIVATE_DEPS
PUBLIC_INCLUDES PRIVATE_INCLUDES
Expand Down Expand Up @@ -192,7 +192,7 @@ function(pw_add_library NAME TYPE)
set(num_positional_args 2)
set(option_args)
set(one_value_args)
_pw_library_multi_value_args(multi_value_args)
_pw_add_library_multi_value_args(multi_value_args)
pw_parse_arguments_strict(
pw_add_library "${num_positional_args}" "${option_args}"
"${one_value_args}" "${multi_value_args}")
Expand Down Expand Up @@ -296,7 +296,7 @@ endfunction(pw_add_library)
# PRIVATE_LINK_OPTIONS - private target_link_options arguments
#
function(pw_add_module_library NAME)
_pw_library_multi_value_args(multi_value_args IMPLEMENTS_FACADES)
_pw_add_library_multi_value_args(multi_value_args IMPLEMENTS_FACADES)
pw_parse_arguments_strict(pw_add_module_library 1 "" "" "${multi_value_args}")

# Check that the library's name is prefixed by the module name.
Expand Down Expand Up @@ -382,7 +382,7 @@ endfunction(pw_add_module_library)
# DEFAULT_BACKEND - which backend to use by default
#
function(pw_add_facade NAME)
_pw_library_multi_value_args(list_args)
_pw_add_library_multi_value_args(list_args)
pw_parse_arguments_strict(pw_add_facade 1 "" "DEFAULT_BACKEND" "${list_args}")

# If no backend is set, a script that displays an error message is used
Expand Down

0 comments on commit 32abf81

Please sign in to comment.