Skip to content

Commit

Permalink
pw_crypto: Bazel file cleanup
Browse files Browse the repository at this point in the history
*  Remove some unnecessary `tags = ["manual"]` attributes (the affected
   targets now build, so there's no reason to exclude them).
*  Simplify the third_party/mbedtls/BUILD.bazel file. This will make it
   easier for users to parse, but also easier for our copybara
   automation to handle.

Change-Id: I047cde9d6de257a40dd6a8e2fa4b65228011694f
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/137792
Reviewed-by: Ali Zhang <[email protected]>
Commit-Queue: Auto-Submit <[email protected]>
Pigweed-Auto-Submit: Ted Pudlik <[email protected]>
  • Loading branch information
tpudlik authored and CQ Bot Account committed Apr 7, 2023
1 parent 68a35ff commit 26ced97
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 20 deletions.
3 changes: 0 additions & 3 deletions pw_crypto/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ pw_cc_library(
"public_overrides/mbedtls/pw_crypto/sha256_backend.h",
],
includes = ["public_overrides/mbedtls"],
tags = ["manual"],
deps = [
":sha256_facade",
"@mbedtls",
Expand Down Expand Up @@ -128,8 +127,6 @@ pw_cc_library(
pw_cc_test(
name = "sha256_mock_test",
srcs = ["sha256_mock_test.cc"],
# TODO(b/236321905): Requires BUILD.bazel files for mbedtls
tags = ["manual"],
deps = [
":sha256_mock",
"//pw_unit_test",
Expand Down
26 changes: 9 additions & 17 deletions third_party/mbedtls/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -21,21 +21,13 @@ package(
default_visibility = ["//visibility:public"],
)

# Ready-made configurations
mbedtls_configs = [
("default", "configs/config_default.h"),
]

# Config targets.
[
pw_cc_library(
name = "%s_config" % config_name,
hdrs = [
config_header,
"configs/config_pigweed_common.h",
],
defines = ['MBEDTLS_CONFIG_FILE=\\"%s\\"' % config_header],
includes = ["."],
)
for config_name, config_header in mbedtls_configs
]
pw_cc_library(
name = "default_config",
hdrs = [
"configs/config_default.h",
"configs/config_pigweed_common.h",
],
defines = ['MBEDTLS_CONFIG_FILE=\\"configs/config_default.h\\"'],
includes = ["."],
)

0 comments on commit 26ced97

Please sign in to comment.