Skip to content

Commit

Permalink
pw_presubmit: Don't rename .ninja_log
Browse files Browse the repository at this point in the history
This was done to make recipe code simpler but is no longer needed. It's
also complicating things because subsequent ninja runs expect the file
to be there.

Change-Id: I1b043a0dbf955f7d030f9b6198d960df8c0e7728
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/114792
Reviewed-by: Jesus Sanchez-Palencia <[email protected]>
Commit-Queue: Auto-Submit <[email protected]>
Pigweed-Auto-Submit: Rob Mohr <[email protected]>
Reviewed-by: Austin Foxley <[email protected]>
  • Loading branch information
mohrr authored and CQ Bot Account committed Oct 14, 2022
1 parent 466defd commit 043d70a
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions pw_presubmit/py/pw_presubmit/build.py
Original file line number Diff line number Diff line change
Expand Up @@ -207,8 +207,6 @@ def ninja(ctx: PresubmitContext,

raise exc

(ctx.output_dir / '.ninja_log').rename(ctx.output_dir / 'ninja.log')


def get_gn_args(directory: Path) -> List[Dict[str, Dict[str, str]]]:
"""Dumps GN variables to JSON."""
Expand Down

0 comments on commit 043d70a

Please sign in to comment.