Merge "ui: move most state from Globals to AppImpl" into main

python/tools/check_ratchet.py

@@ -36,7 +36,7 @@
 
 from dataclasses import dataclass
 
-EXPECTED_ANY_COUNT = 61
+EXPECTED_ANY_COUNT = 58
 EXPECTED_RUN_METRIC_COUNT = 5
 
 ROOT_DIR = os.path.dirname(

ui/src/common/empty_state.ts

@@ -126,9 +126,6 @@ export function createEmptyState(): State {
     chromeCategories: undefined,
     nonSerializableState: createEmptyNonSerializableState(),
 
-    // Somewhere to store plugins' persistent state.
-    plugins: {},
-
     trackFilterTerm: undefined,
     forceRunControllers: 0,
   };

ui/src/common/fake_trace_impl.ts

@@ -0,0 +1,46 @@
+// Copyright (C) 2024 The Android Open Source Project
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+import {Time} from '../base/time';
+import {AppImpl} from '../core/app_trace_impl';
+import {TraceInfo} from '../public/trace_info';
+import {EngineBase} from '../trace_processor/engine';
+
+class FakeEngine extends EngineBase {
+  id: string = 'TestEngine';
+
+  rpcSendRequestBytes(_data: Uint8Array) {
+    throw new Error('FakeEngine.query() should never be reached');
+  }
+}
+
+// This is used:
+// - For testing.
+// - By globals.ts before we have an actual trace loaded, to avoid causing
+//   if (!= undefined) checks everywhere.
+export function createFakeTraceImpl() {
+  const fakeTraceInfo: TraceInfo = {
+    source: {type: 'URL', url: ''},
+    traceTitle: '',
+    traceUrl: '',
+    start: Time.fromSeconds(0),
+    end: Time.fromSeconds(10),
+    realtimeOffset: Time.ZERO,
+    utcOffset: Time.ZERO,
+    traceTzOffset: Time.ZERO,
+    cpus: [],
+    gpuCount: 0,
+  };
+  return AppImpl.instance.newTraceInstance(new FakeEngine(), fakeTraceInfo);
+}