Skip to content

Commit

Permalink
heapprofd: Fix outdated log message
Browse files Browse the repository at this point in the history
At the beginning, heapprofd could work in two modes on android:
* Central, where each app connects to the central heapprofd daemon.
* Fork, where each app starts its own heapprofd daemon.

On android user builds, only fork mode was supported. An app would try
to connect to the central heapprofd daemon, it would fail and then it
would start its own heapprofd daemon in fork mode.

The log message made sense.

Then, central mode started to be supported on user builds and fork mode
was removed on android.

Since https://r.android.com/1536299, the log message doesn't make sense
anymore.

Change-Id: I5e53953329c57447e3a69c3cabd4ce9b891496ce
  • Loading branch information
ddiproietto committed Nov 15, 2024
1 parent 0fd224e commit d6ac03f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/profiling/memory/client_api_factory_android.cc
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ std::shared_ptr<Client> ConstructClient(
std::optional<perfetto::base::UnixSocketRaw> sock =
Client::ConnectToHeapprofd(perfetto::profiling::kHeapprofdSocketFile);
if (!sock) {
PERFETTO_ELOG("Failed to connect to %s. This is benign on user builds.",
PERFETTO_ELOG("Failed to connect to %s.",
perfetto::profiling::kHeapprofdSocketFile);
return nullptr;
}
Expand Down

0 comments on commit d6ac03f

Please sign in to comment.