Merge "protozero: mark constchars as hashable" into main

google · Nov 25, 2024 · b094411 · b094411
2 parents 421e518 + 9391393
commit b094411
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/include/perfetto/protozero/field.h b/include/perfetto/protozero/field.h
@@ -20,6 +20,7 @@
 #include <stdint.h>
 
 #include <string>
+#include <string_view>
 #include <vector>
 
 #include "perfetto/base/logging.h"
@@ -41,7 +42,9 @@ struct ConstChars {
   // Allow implicit conversion to perfetto's base::StringView without depending
   // on perfetto/base or viceversa.
   static constexpr bool kConvertibleToStringView = true;
-  std::string ToStdString() const { return std::string(data, size); }
+  static constexpr bool kHashable = true;
+  std::string ToStdString() const { return {data, size}; }
+  std::string_view ToStdStringView() const { return {data, size}; }
 
   const char* data;
   size_t size;