Skip to content

Commit

Permalink
Merge "ui: Don't add ftrace tab by default" into main
Browse files Browse the repository at this point in the history
  • Loading branch information
stevegolton authored and Gerrit Code Review committed Mar 4, 2024
2 parents a9c8661 + 08ddbeb commit 3fe34e7
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 19 deletions.
Original file line number Diff line number Diff line change
@@ -1 +1 @@
71f0799ce780f36dbdeb601ba535ee012b7323afc57254a5b383704ec384da62
d12dc4f32f544a32bca4302314d7eb4984a3e6473d78298435396c7f81522564
Original file line number Diff line number Diff line change
@@ -1 +1 @@
725ff7289949bda82fc4c2d454e1ee0b4218b3d56f20c1098d6fa7914ef19bfc
2273d163c13ea0e296492ba30a2669c70d0e5ab050317c17f108a1836052c908
Original file line number Diff line number Diff line change
@@ -1 +1 @@
bd495271f97ffe17851f6605acaf24463c2363cb6a4bcf8e1b3fd78b9e18353f
d9539daa1cf9a5b621377ed5e4be164adfee64f9f320caa7b0d1abc584276427
16 changes: 0 additions & 16 deletions ui/src/tracks/ftrace/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -165,10 +165,6 @@ class FtraceRawPlugin implements Plugin {
},
});

if (await this.hasFtrace(ctx.engine)) {
ctx.addDefaultTab(ftraceTabUri);
}

ctx.registerCommand({
id: 'perfetto.FtraceRaw#ShowFtraceTab',
name: 'Show Ftrace Tab',
Expand All @@ -178,18 +174,6 @@ class FtraceRawPlugin implements Plugin {
});
}

private async hasFtrace(engine: EngineProxy): Promise<boolean> {
// Check if we have any ftrace events at all
const query = `
select
*
from ftrace_event
limit 1`;

const res = await engine.query(query);
return res.numRows() > 0;
}

private async lookupCpuCores(engine: EngineProxy): Promise<number[]> {
const query = 'select distinct cpu from ftrace_event';

Expand Down

0 comments on commit 3fe34e7

Please sign in to comment.