[ui] Bugfix: Debug tracks not auto-pinning.

Bug: 306378462 Change-Id: I94d687ac5d69fcf54c93d51ebda1fa13ed31b671
google · Oct 19, 2023 · 39cd110 · 39cd110
1 parent d568b37
commit 39cd110
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 20 deletions.
diff --git a/ui/src/tracks/debug/counter_track.ts b/ui/src/tracks/debug/counter_track.ts
@@ -13,6 +13,7 @@
 // limitations under the License.
 
 import m from 'mithril';
+import {v4 as uuidv4} from 'uuid';
 
 import {Actions, DEBUG_COUNTER_TRACK_KIND} from '../../common/actions';
 import {EngineProxy} from '../../common/engine';
@@ -103,14 +104,19 @@ export async function addDebugCounterTrack(
       from data
       order by ts;`);
 
-  globals.dispatch(Actions.addTrack({
-    uri: DEBUG_COUNTER_TRACK_URI,
-    name: trackName.trim() || `Debug Track ${debugTrackId}`,
-    trackSortKey: PrimaryTrackSortKey.DEBUG_TRACK,
-    trackGroup: SCROLLING_TRACK_GROUP,
-    initialState: {
-      sqlTableName,
-      columns,
-    },
-  }));
+  const trackInstanceId = uuidv4();
+  globals.dispatchMultiple([
+    Actions.addTrack({
+      id: trackInstanceId,
+      uri: DEBUG_COUNTER_TRACK_URI,
+      name: trackName.trim() || `Debug Track ${debugTrackId}`,
+      trackSortKey: PrimaryTrackSortKey.DEBUG_TRACK,
+      trackGroup: SCROLLING_TRACK_GROUP,
+      initialState: {
+        sqlTableName,
+        columns,
+      },
+    }),
+    Actions.toggleTrackPinned({trackId: trackInstanceId}),
+  ]);
 }
diff --git a/ui/src/tracks/debug/slice_track.ts b/ui/src/tracks/debug/slice_track.ts
@@ -13,6 +13,7 @@
 // limitations under the License.
 
 import m from 'mithril';
+import {v4 as uuidv4} from 'uuid';
 
 import {Disposable} from '../../base/disposable';
 import {Actions, DEBUG_SLICE_TRACK_KIND} from '../../common/actions';
@@ -145,14 +146,19 @@ export async function addDebugSliceTrack(
       from prepared_data
       order by ts;`);
 
-  globals.dispatch(Actions.addTrack({
-    uri: DEBUG_SLICE_TRACK_URI,
-    name: trackName.trim() || `Debug Track ${debugTrackId}`,
-    trackSortKey: PrimaryTrackSortKey.DEBUG_TRACK,
-    trackGroup: SCROLLING_TRACK_GROUP,
-    initialState: {
-      sqlTableName,
-      columns: sliceColumns,
-    },
-  }));
+  const trackInstanceId = uuidv4();
+  globals.dispatchMultiple([
+    Actions.addTrack({
+      id: trackInstanceId,
+      uri: DEBUG_SLICE_TRACK_URI,
+      name: trackName.trim() || `Debug Track ${debugTrackId}`,
+      trackSortKey: PrimaryTrackSortKey.DEBUG_TRACK,
+      trackGroup: SCROLLING_TRACK_GROUP,
+      initialState: {
+        sqlTableName,
+        columns: sliceColumns,
+      },
+    }),
+    Actions.toggleTrackPinned({trackId: trackInstanceId}),
+  ]);
 }