Merge "ui: Group all old openTable into Chrometto plugin" into main

src/trace_processor/perfetto_sql/stdlib/prelude/after_eof/tables_views.sql

@@ -228,7 +228,7 @@ FROM sched_slice;
 --
 -- The rows in this table which have |state| = 'Running', will have a
 -- corresponding row in the |sched_slice| table.
-CREATE PERFETTO VIEW thread_state (
+CREATE PERFETTO VIEW thread_state(
   -- Unique identifier for this thread state.
   id ID,
   -- The name of the "most-specific" child table containing this row.

ui/src/core/default_plugins.ts

@@ -68,6 +68,7 @@ export const defaultPlugins = [
   'dev.perfetto.TraceMetadata',
   'dev.perfetto.VizPage',
   'org.chromium.CriticalUserInteraction',
+  'org.Chromium.OpenTableCommands',
   'org.kernel.LinuxKernelSubsystems',
   'org.kernel.SuspendResumeLatency',
   'org.kernel.Wattson',

ui/src/plugins/dev.perfetto.AndroidLog/index.ts

@@ -17,13 +17,10 @@ import {LogFilteringCriteria, LogPanel} from './logs_panel';
 import {ANDROID_LOGS_TRACK_KIND} from '../../public/track_kinds';
 import {Trace} from '../../public/trace';
 import {PerfettoPlugin} from '../../public/plugin';
-import {sqlTableRegistry} from '../../components/widgets/sql/table/sql_table_registry';
 import {NUM} from '../../trace_processor/query_result';
 import {AndroidLogTrack} from './logs_track';
 import {exists} from '../../base/utils';
 import {TrackNode} from '../../public/workspace';
-import {getAndroidLogsTable} from './table';
-import {extensions} from '../../components/extensions';
 
 const VERSION = 1;
 
@@ -97,16 +94,5 @@ export default class implements PerfettoPlugin {
         ctx.tabs.showTab(androidLogsTabUri);
       },
     });
-
-    sqlTableRegistry['android_logs'] = getAndroidLogsTable();
-    ctx.commands.registerCommand({
-      id: 'perfetto.ShowTable.android_logs',
-      name: 'Open table: android_logs',
-      callback: () => {
-        extensions.addSqlTableTab(ctx, {
-          table: getAndroidLogsTable(),
-        });
-      },
-    });
   }
 }

ui/src/plugins/dev.perfetto.AsyncSlices/index.ts

@@ -23,9 +23,6 @@ import {AsyncSliceTrack} from './async_slice_track';
 import {exists} from '../../base/utils';
 import {assertExists, assertTrue} from '../../base/logging';
 import {SliceSelectionAggregator} from './slice_selection_aggregator';
-import {sqlTableRegistry} from '../../components/widgets/sql/table/sql_table_registry';
-import {getSliceTable} from './table';
-import {extensions} from '../../components/extensions';
 import ProcessThreadGroupsPlugin from '../dev.perfetto.ProcessThreadGroups';
 
 export default class implements PerfettoPlugin {
@@ -74,18 +71,6 @@ export default class implements PerfettoPlugin {
     ctx.selection.registerAreaSelectionAggregator(
       new SliceSelectionAggregator(),
     );
-
-    sqlTableRegistry['slice'] = getSliceTable();
-
-    ctx.commands.registerCommand({
-      id: 'perfetto.ShowTable.slice',
-      name: 'Open table: slice',
-      callback: () => {
-        extensions.addSqlTableTab(ctx, {
-          table: getSliceTable(),
-        });
-      },
-    });
   }
 
   async addGlobalAsyncTracks(

ui/src/plugins/dev.perfetto.Sched/index.ts

@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-import {sqlTableRegistry} from '../../components/widgets/sql/table/sql_table_registry';
 import {TrackNode} from '../../public/workspace';
 import {Trace} from '../../public/trace';
 import {PerfettoPlugin} from '../../public/plugin';
@@ -21,8 +20,6 @@ import {
   RunnableThreadCountTrack,
   UninterruptibleSleepThreadCountTrack,
 } from './thread_count';
-import {getSchedTable} from './table';
-import {extensions} from '../../components/extensions';
 
 export default class implements PerfettoPlugin {
   static readonly id = 'dev.perfetto.Sched';
@@ -88,17 +85,6 @@ export default class implements PerfettoPlugin {
         callback: () => addPinnedTrack(ctx, uri, title),
       });
     }
-
-    sqlTableRegistry['sched'] = getSchedTable();
-    ctx.commands.registerCommand({
-      id: 'perfetto.ShowTable.sched',
-      name: 'Open table: sched',
-      callback: () => {
-        extensions.addSqlTableTab(ctx, {
-          table: getSchedTable(),
-        });
-      },
-    });
   }
 }
 

ui/src/plugins/dev.perfetto.Thread/index.ts

@@ -12,11 +12,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-import {sqlTableRegistry} from '../../components/widgets/sql/table/sql_table_registry';
 import {Trace} from '../../public/trace';
 import {PerfettoPlugin} from '../../public/plugin';
-import {getThreadTable} from './table';
-import {extensions} from '../../components/extensions';
 import {ThreadDesc, ThreadMap} from '../dev.perfetto.Thread/threads';
 import {NUM, NUM_NULL, STR, STR_NULL} from '../../trace_processor/query_result';
 import {assertExists} from '../../base/logging';
@@ -61,16 +58,6 @@ export default class implements PerfettoPlugin {
   private threads?: ThreadMap;
 
   async onTraceLoad(ctx: Trace) {
-    sqlTableRegistry['thread'] = getThreadTable();
-    ctx.commands.registerCommand({
-      id: 'perfetto.ShowTable.thread',
-      name: 'Open table: thread',
-      callback: () => {
-        extensions.addSqlTableTab(ctx, {
-          table: getThreadTable(),
-        });
-      },
-    });
     this.threads = await listThreads(ctx);
   }