tp: Ban SELECT IMPORT in stdlib and metrics

Bug:296397580 Bug:296388363 Change-Id: I4bf7d7b713b6f7abf916e0b80703515e59ff648d
google · Aug 29, 2023 · 10dc645 · 10dc645
1 parent 3500f14
commit 10dc645
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/python/generators/sql_processing/utils.py b/python/generators/sql_processing/utils.py
@@ -129,6 +129,11 @@ def check_banned_words(sql: str, path: str) -> List[str]:
       errors.append('CREATE_FUNCTION is deprecated in trace processor. '
                     'Use CREATE PERFETTO FUNCTION instead.\n'
                     f'Offending file: {path}')
+
+    if 'import(' in line.casefold():
+      errors.append('SELECT IMPORT is deprecated in trace processor. '
+                    'Use INCLUDE PERFETTO MODULE instead.\n'
+                    f'Offending file: {path}')
   return errors