Skip to content

Commit

Permalink
stdlib: Support AIDL::ndk in android.binder module
Browse files Browse the repository at this point in the history
NDK binder tracing was recently added in aosp/3197053.
Removed special case for only Java and CPP AIDL calls

Test: tools/diff_test_trace_processor.py out/android/trace_processor_shell --name-filter '.*binder.*'
Change-Id: I11905905567e7f4652d2f31c9d24048183718432
  • Loading branch information
zezeozue committed Oct 14, 2024
1 parent 6913264 commit 0a27255
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions src/trace_processor/perfetto_sql/stdlib/android/binder.sql
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,9 @@ WITH maybe_broken_binder_txn AS (
JOIN thread reply_thread ON reply_thread.utid = reply_thread_track.utid
JOIN process reply_process ON reply_process.upid = reply_thread.upid
LEFT JOIN slice aidl ON aidl.parent_id = binder_reply.id
AND (aidl.name GLOB 'AIDL::cpp*Server'
OR aidl.name GLOB 'AIDL::java*server'
-- Filter for only server side AIDL slices as there are some client side ones for cpp
AND (aidl.name GLOB 'AIDL::*Server'
OR aidl.name GLOB 'AIDL::*server'
OR aidl.name GLOB 'HIDL::*server')
)
SELECT
Expand Down Expand Up @@ -323,8 +324,9 @@ WITH async_reply AS MATERIALIZED (
SELECT id, ts, dur, track_id, name
FROM slice
WHERE
name GLOB 'AIDL::cpp*Server'
OR name GLOB 'AIDL::java*server'
-- Filter for only server side AIDL slices as there are some client side ones for cpp
name GLOB 'AIDL::*Server'
OR name GLOB 'AIDL::*server'
OR name GLOB 'HIDL::*server'
OR name = 'binder async rcv'
) SELECT *, LEAD(name) OVER (PARTITION BY track_id ORDER BY ts) AS next_name,
Expand Down

0 comments on commit 0a27255

Please sign in to comment.