Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move workers and indexer out of docker/ into gcp/ #2938

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

michaelkedar
Copy link
Member

#1714
Move the indexer to gcp/indexer and the python workers into gcp/workers/, so our deployed code is more together and separated from our ci stuff.

I also want to deal with the shared worker Dockerfile & poetry environment, but this PR already involved a lot of potentially risky renaming so I've started with this.

Copy link
Contributor

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though it's a bit hard to tell whether things will break or not.

Copy link
Contributor

@hogo6002 hogo6002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe we can merge this after next week's release to allow for more bake time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants