Remove --hash from version in requirements.txt #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes everything after the whitespace of the version to also catch the other per-requirement options --global-option and --config-settings and any future options that may be added https://pip.pypa.io/en/stable/reference/requirements-file-format/#per-requirement-options fixes: google#369 # Conflicts: # pkg/lockfile/parse-requirements-txt_test.go
While addressing google#369 i noticed the pip documentation example for --hash used line continuations which weren't currently supported by this parser so i've added support for line continuations
robotdana
force-pushed
the
requirements_text_version_meta
branch
from
7f238ce to
1623b97
Compare
G-Rath
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes everything after the whitespace of the version to also
catch the other per-requirement options --global-option and
--config-settings and any future options that may be added
https://pip.pypa.io/en/stable/reference/requirements-file-format/#per-requirement-options
fixes: #369
While addressing this i noticed the pip documentation example for --hash
used line continuations which weren't currently supported by this parser
so i've added support for this