test: add output fixtures for call analysis #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This unblocks support call analysis in #889 |
G-Rath
force-pushed
the
tests/add-called-output-fixtures
branch
3 times, most recently
from
3ba0472 to
eb0eb1f
Compare
G-Rath
force-pushed
the
tests/add-called-output-fixtures
branch
from
eb0eb1f to
dff227a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1093 +/- ##
=======================================
Coverage 65.94% 65.94%
=======================================
Files 159 159
Lines 12758 12758
=======================================
Hits 8413 8413
Misses 3885 3885
Partials 460 460 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fixtures were based on the output from the
cmd/osv-scanner/fixtures/call-analysis-go-projectfixture, though from the struct I think it's pretty complete; the most notable thing is it looks like call analysis does play favorites unlike most of the scanner: only one advisory of a vulnerability will be marked as called/uncalled regardless of how many aliases that vulnerability has.