Transitive dependency support for Maven pom.xml #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1002 +/- ##
==========================================
+ Coverage 64.47% 65.06% +0.59%
==========================================
Files 148 149 +1
Lines 12088 12250 +162
==========================================
+ Hits 7794 7971 +177
+ Misses 3843 3832 -11
+ Partials 451 447 -4 ☔ View full report in Codecov by Sentry. |
cuixq
commented
May 29, 2024
| <dependencies> | ||
| <dependency> | ||
| <groupId>junit</groupId> | ||
| <artifactId>junit</artifactId> | ||
| <version>4.12</version> | ||
| <scope>test</scope> |
There was a problem hiding this comment.
@michaelkedar I think we should fix the resolver not to ignore test dependencies. junit:junit is not in the resolve graph. :(
michaelkedar
approved these changes
May 31, 2024
josieang
pushed a commit
to josieang/osv-scanner
that referenced
this pull request
Jun 6, 2024
Issue google#35 In this PR, the new Maven extractor invokes Maven resolver to compute the transitive dependencies of a Maven pom.xml. Since managed dependencies are not actually being depended on, they are not in the resolved dependency graph, and thus they are not included in the scan results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #35
In this PR, the new Maven extractor invokes Maven resolver to compute the transitive dependencies of a Maven pom.xml.
Since managed dependencies are not actually being depended on, they are not in the resolved dependency graph, and thus they are not included in the scan results.