-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable -Werror on unused-command-line-argument #9030
Conversation
@oliverchang: I reckon this solution is cleaner than what we discussed.
Would you think this could be a good solution? Thanks! |
/gcbrun trial_build.py all --sanitizer address --fuzzing-engine centipede |
nice solution! is this heavily dependent on the order of flags though? i.e. is there a dependency on the -Werror coming before/after what we specify here? |
Nope, I tested it locally: it can come either before or after |
This is great then :) Nice suggestion! |
/gcbrun trial_build.py all --sanitizer none --fuzzing-engine centipede |
This failed only on project OSError: [Errno 28] No space left on device I tested |
Some projects use `-Werror` to turn all warnings into errors. This affects `Centipede` as we do not separate build and linking flags as it expects, which leads to `unused-command-line-argument` warnings. This PR disables turning that specific warning into errors and keeps the rest the same. See [the same PR from OSS-Fuzz](google/oss-fuzz#9030) for more info and [the error in this PR](google/oss-fuzz#8990) for its use case.
Some projects use `-Werror` to turn all warnings into errors. This affects `Centipede` as we do not separate build and linking flags as it expects, which leads to `unused-command-line-argument` warnings. This PR disables turning that specific warning into errors and keeps the rest the same.
Some projects use
-Werror
to turn all warnings into errors.This affects
Centipede
as we do not separate build and linking flags as it expects, which leads tounused-command-line-argument
warnings.This PR disables turning that specific warning into errors and keeps the rest the same.