-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
native go fuzzing: Restrict fuzzer lookup to *.go
#8238
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The |
Looks still failing? |
Yes, I tested the same version of the code base without my changes and the error was still there. I wonder whether something broke that test since the last time it passed. The last successful run was triggered by the Comparing the changes since last pass I could not find anything I could point out as the issue. But I am not very familiar with the code base, so any help would be greatly appreciated. |
The failure does not seem related to your change, it is from our infra: Let's see how |
/gcbrun trial_build.py smt helm --sanitizer address --fuzzing-engine libfuzzer |
Projects containing words starting with Fuzz in non-go files break compile_native_go_fuzzer with the error: sed: -e expression #1, char 15: unknown option to 's' Signed-off-by: Paulo Gomes <[email protected]>
Merging this as the |
Actually not yet! |
Passed! |
@Navidem thank you for pushing this through. 🙇 |
Projects containing words starting with Fuzz in non-go files break
compile_native_go_fuzzer
with the error:sed: -e expression #1, char 15: unknown option to 's'