Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[elfutils] drop unused static libraries #7412

Closed
wants to merge 1 commit into from

Conversation

evverx
Copy link
Contributor

@evverx evverx commented Mar 21, 2022

fuzz-libdwfl and fuzz-libelf have to be linked against libelf and
libdw. The other static libraries just make the fuzz targets
unnecessarily larger. Without those libraries it's also possible to
simplify the build script a bit.

fuzz-libdwfl and fuzz-libelf have to be linked against libelf and
libdw. The other static libraries just make the fuzz targets
unnecessarily larger. Without those libraries it's also possible to
simplify the build script a bit.
@evverx evverx marked this pull request as draft March 21, 2022 10:37
@evverx evverx closed this Mar 21, 2022
@DavidKorczynski
Copy link
Collaborator

See here for a reference on the next steps forward I had in mind: #7395 (comment)

The idea was to add fuzzers for all of the libraries in elfutils and thus I included them with the intentions of converting it to a loop like this down the line but with all the other libraries included. Similar to what we did in net-snmp https://github.com/net-snmp/net-snmp/blob/8e14effb6626bbf5bc344ec17fdf0354b5b9a90d/testing/fuzzing/build-fuzz-tests.sh#L7-L20 where many fuzzers dont need all of the libraries linked in

@DavidKorczynski
Copy link
Collaborator

ah - you're too fast for me @evverx :)! Will comment in my PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants