Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: drop out-of-date paragraph #7403

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Conversation

evverx
Copy link
Contributor

@evverx evverx commented Mar 20, 2022

Issues like https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=45628
aren't always reproducible with libFuzzer so to really trigger them using
the OSS-Fuzz toolchain they should be built and run with engines used to
trigger them originally. reproduce supports them now.

Issues like https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=45628
aren't always reproducible with libFuzzer so to really trigger them using
the OSS-Fuzz toolchain they should be built and run with engines used to
trigger them originally. `reproduce` supports them now.
@evverx
Copy link
Contributor Author

evverx commented Mar 20, 2022

Just to clarify when the fuzz target is built with libfuzzer the buffer contains \0 there which prevents strtol from getting past the end of the buffer.

@evverx
Copy link
Contributor Author

evverx commented Mar 20, 2022

FWIW since CFLite supports libfuzzer only I couldn't use it to trigger the issue and verify the patch fixing it. It would be great if it could support AFL or honggfuzz too.

@evverx
Copy link
Contributor Author

evverx commented Mar 20, 2022

What's weird is that I can trigger it with libfuzzer sometimes but with AFL, honggfuzz and valgrind it's reproducible 100% and judging by https://oss-fuzz.com/testcase-detail/4673586076450816 clusterfuzz can't trigger it with libfuzzer/asan reliably either. I'm puzzled.

@evverx
Copy link
Contributor Author

evverx commented Mar 21, 2022

What's even weirder is that OSS-Fuzz reported basically the same issue in https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=45636. It was found with AFL++ and isn't reliably reproducible with libFuzzer either. I wonder why they weren't deduplicated?

Copy link
Collaborator

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot as always!

@oliverchang
Copy link
Collaborator

What's even weirder is that OSS-Fuzz reported basically the same issue in https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=45636. It was found with AFL++ and isn't reliably reproducible with libFuzzer either. I wonder why they weren't deduplicated?

Re your question on why they weren't deduplicated, it looks like the crash types / state generated from both were different enough such that ClusterFuzz considered them two separate bugs. We have a long standing bug to improve this here (google/clusterfuzz#1177), but this has some complexity that meant we haven't justified prioritising this.

@oliverchang oliverchang merged commit 189c961 into google:master Mar 21, 2022
MartinPetkov pushed a commit to MartinPetkov/oss-fuzz that referenced this pull request Aug 15, 2022
Issues like https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=45628
aren't always reproducible with libFuzzer so to really trigger them using
the OSS-Fuzz toolchain they should be built and run with engines used to
trigger them originally. `reproduce` supports them now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants