infra: add support for netdriver fuzzing with honggfuzz #7351
Conversation
|
I think this could face some of the issues mentioned in #7347 |
|
Sorry for late response, I think this can be useful /* HF NetDriver signature - if found within file, it means it's a NetDriver-based binary */
#define _HF_NETDRIVER_SIG "\x01_LIBHFUZZ_NETDRIVER_BINARY_SIGNATURE_\x02\xFF" |
|
@jonathanmetzman -- you approved this but I wanted to double check if it's ready before merging it in? |
Adds an example with the mongoose webserver
One thing left is removing the definitions from the build.sh currently defined by way of the compile line into the compile_honggfuzz
DavidKorczynski
force-pushed
the
honggfuzz-netdriver-mongoose
branch
from
ab3845b to
6833c6e
Compare
| HFND_FUZZING_ENTRY_FUNCTION(int argc, char **argv) { | ||
| struct mg_mgr mgr; | ||
| mg_mgr_init(&mgr); | ||
| mg_http_listen(&mgr, "http://0.0.0.0:8666", fn, &mgr); |
There was a problem hiding this comment.
This will have some issues when we have multiple fuzzers. Because we run bad_build_check on all of them at once but they can't use the same port.
There was a problem hiding this comment.
True, would you prefer to address this now? One solution is to scan the fuzzers and check if there is more than one fuzzer with netdriver settings, and, if so, avoid running the fuzzers in parallel.
There was a problem hiding this comment.
I'm not sure if that's the case here, but hf netdriver uses net namespaces just for that. It should work with a single/same port per fuzzing thread.
|
/gcbrun trial_build.py mongoose --sanitizer address coverage memory undefined --fuzzing-engine libfuzzer afl honggfuzz |
|
Trial builds don't work here because they don't work on forked repos :-( |
Do I need to do something to make this work, or how do you prefer to move forward? |
The changes look relatively self contained, so let's merge. Going forward, for infra-related PRs like these, can you create them off a branch on the main repo instead? |
It shouldn't be too hard to support forks, I'm just avoiding implementing this to reduce bus factor: #8273 |
Adds an example with the mongoose webserver