Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert msan patch #4788

Merged
merged 2 commits into from
Dec 5, 2020
Merged

Revert msan patch #4788

merged 2 commits into from
Dec 5, 2020

Conversation

inferno-chromium
Copy link
Collaborator

Traceback (most recent call last):
  File "/usr/local/bin/msan_build.py", line 459, in <module>
    main()
  File "/usr/local/bin/msan_build.py", line 455, in main
    builder.build(package_name, args.output_dir, args.create_subdirs)
  File "/usr/local/bin/msan_build.py", line 368, in build
    pkg = get_package(package_name)
  File "/usr/local/bin/msan_build.py", line 255, in get_package
    return module.Package(version)
  File "/usr/local/bin/packages/nettle.py", line 37, in __init__
    super(Package, self).__init__('nettle', apt_version)
TypeError: super() argument 1 must be type, not classobj

@inferno-chromium
Copy link
Collaborator Author

Not building at all and affecting base builder change.

@inferno-chromium inferno-chromium merged commit b9e6a5f into master Dec 5, 2020
@oliverchang
Copy link
Collaborator

thanks!

@divergentdave
Copy link
Contributor

This was probably due to e510d35. We should ignore the useless-object-inheritance lint instead, as these scripts still need to run in Python 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants