Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding libra to list of projects #3382

Merged
merged 1 commit into from
Feb 13, 2020
Merged

adding libra to list of projects #3382

merged 1 commit into from
Feb 13, 2020

Conversation

mimoo
Copy link
Contributor

@mimoo mimoo commented Feb 13, 2020

Hey!

I'd like to add libra to oss fuzz. Here is the project repository.

Thanks!

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@TravisBuddy
Copy link

Hey @mimoo,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: f7ca9f50-4e90-11ea-a3d3-1b6c403325ec

@mimoo
Copy link
Contributor Author

mimoo commented Feb 13, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@inferno-chromium inferno-chromium merged commit 48a907e into google:master Feb 13, 2020
@inferno-chromium
Copy link
Collaborator

Welcome to OSS-Fuzz!

@jonathanmetzman
Copy link
Contributor

Rust fuzzing should 100% work and we are eager to support it.
But there is one sharp edge I know of that I haven't gotten around to investigating, you should probably look at this.
Also, some runtime changes were made by the the first rust project integrated, I'm not sure if those are generally needed: ec58a65 94d0c3a

@mimoo
Copy link
Contributor Author

mimoo commented Feb 14, 2020

thanks for the pointer! I'll report back if I run into troubles :)

@jonathanmetzman jonathanmetzman mentioned this pull request Feb 17, 2020
@mimoo
Copy link
Contributor Author

mimoo commented Feb 26, 2020

Is there anyway to accept multiple fuzzers as one binary? The way we currently run our fuzzers is that we add a environment variable that specifies which fuzzer it is.

Otherwise I'll have to look into creating separate binaries.

EDIT: made it work on my end

@Dor1s
Copy link
Contributor

Dor1s commented Feb 27, 2020

OSS-Fuzz model requires multiple binaries. See https://github.com/google/oss-fuzz/pull/431/files for example

@mimoo
Copy link
Contributor Author

mimoo commented Mar 3, 2020

Looks like it takes us more than the 70GB limit to build our fuzzers in release mode 😄 any way to increase this?

@Dor1s
Copy link
Contributor

Dor1s commented Mar 4, 2020

Are you seeing a failure anywhere, or you've read about 70GB limit in

Our builders have a disk size of 70GB (this includes space taken up by the OS). Builds must keep peak disk usage below this.
?

I see that actual limit is higher, so unless you experience a failure, we should probably fix the docs instead :)

@mimoo
Copy link
Contributor Author

mimoo commented Mar 5, 2020

that's how I had set my docker settings, with more memory it builds!

Dor1s added a commit that referenced this pull request Mar 6, 2020
@Dor1s
Copy link
Contributor

Dor1s commented Mar 6, 2020

Ack, I've updated the doc in 072457f, sorry for the confusion!

@mimoo
Copy link
Contributor Author

mimoo commented Mar 9, 2020

question: is there a way to invite someone (who hasn't been CC'ed) to a finding?

@Dor1s
Copy link
Contributor

Dor1s commented Mar 9, 2020

I've granted your gmail account EditIssueCc rights, you should be able to manually CC people on Monorail issues.

@mimoo
Copy link
Contributor Author

mimoo commented Mar 23, 2020

one question: is it possible to grant this to more people/non-google accounts? Also, is there a way on your side to create a distribution list that gets CC'ed? (We can do it on our side, but I'm not sure how it'll work when everybody tries to login as [email protected] on our list.)

@inferno-chromium
Copy link
Collaborator

inferno-chromium commented Mar 23, 2020

You can add a mailing list in auto_ccs in project.yaml, that sends them email about monorail bug when it is filed, but they wont be able to login to ClusterFuzz interface since that requires individual login.

@mimoo
Copy link
Contributor Author

mimoo commented Mar 23, 2020

what if everyone logs in as [email protected]?

@inferno-chromium
Copy link
Collaborator

Then it should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants