Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vulkan-loader: include "loader_json.h"instead of "cJSON.h" #12799

Conversation

charles-lunarg
Copy link
Contributor

@DavidKorczynski Fix of the build - in the update to cJSON I moved the loader specific functions to loader_json.h/.c which breaks one of the original fuzzers. This updates that fuzzer to include what should be the correct file.

Copy link

charles-lunarg is either the primary contact or is in the CCs list of projects/vulkan-loader.
charles-lunarg is a new contributor to projects/vulkan-loader. The PR must be approved by known contributors before it can be merged. The past contributors are: MykolaMykhno

Copy link
Collaborator

@DavidKorczynski DavidKorczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @charles-lunarg -- I think this is the fix we need: #12800

I tested your suggestion locally but we're running into the same issue as shown in https://oss-fuzz-build-logs.storage.googleapis.com/log-e8c38e7d-531c-4b0f-b7ce-40037aae4c9a.txt

@DavidKorczynski
Copy link
Collaborator

It's building again now: https://oss-fuzz-build-logs.storage.googleapis.com/index.html#vulkan-loader

Fix from #12800 solved it.

@charles-lunarg
Copy link
Contributor Author

Yep, I was just trying to get the ball rolling (and didnt actually try to build oss-fuzz). Appreciate you coming in and fixing the real problem.

@charles-lunarg charles-lunarg deleted the charles_lunarg_fix_vulkan_loader_include branch December 12, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants