Apache poi various smaller changes #12725
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
centic9
commented
Nov 17, 2024
centic9
commented
- Update JDK 8 and 11 to latest patch-levels
- Revert version of log4j-core to match revert done to log4j-api by Apache POI to avoid build failures. See log4j-api 2.24.1 causes getLogger() to return null when using log4j-core 2.24.0 apache/logging-log4j2#3196 for details of the issue in log4j
- Fix presubmit-checks for Apache POI
- Print out which file fails checks in presubmit.py to aid in finding the culprit
Apache POI downgraded log4j-api due to issue apache/logging-log4j2#3196 The upcoming log4j-(api|core) 2.24.2 hopefully will be forward/backwards compatible again
Otherwise it is hard to find out which Dockerfile actually failed the checks.
Add apt-get update before apt-get install to make presubmit.py succeed again.
|
centic9 has previously contributed to projects/apache-poi. The previous PR was #12589 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.