-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clang 18.1 remove rust pins #12555
Clang 18.1 remove rust pins #12555
Conversation
now that base-builder-rust uses a more modern one
catenacyber is a new contributor to projects/libressl. The PR must be approved by known contributors before it can be merged. The past contributors are: maflcko, guidovranken, joshuasing, gilles-peskine-arm, DonggeLiu, botovq, Navidem, devtty1er, Dor1s, busterb (unverified), inferno-chromium |
a40ca2d
to
73e46ef
Compare
cc @maflcko we will see with CI which projects fail for unpinning |
All projects that need modifications should still be failing, for example quiche, see #12094. Also, CI may not be able to compile all of them in the limited time, so it may be better to unpin them in "batches" or one-by-one? But up to you. Either way seems fine, if it works. |
projects/opencv/Dockerfile
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this file, and all files that have OLD_LLVMPASS
set: I think you can remove it as well, if the unpin really works, but I haven't tried it myself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean to remove all the lines like projects/bearssl/Dockerfile:ENV OLD_LLVMPASS 1
?
I can try that.
But let me first get a green CI ;-)
Indeed
There are 20 projects, I hope CI can handle it |
now that clang was updated ton 18.1 and nightly is more recent
9eb9061
to
ffa6bbb
Compare
A draft following #12365 and plan to cherry-pick e0d6875