charts/yeti Yeti Helm Chart #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomchop
requested changes
Dec 12, 2023
|
@tomchop with the API key gen fix merged and all tests passing if you can just take a last glance and LGTM if it checks out |
tomchop
approved these changes
Jan 4, 2024
| - condition: global.yeti.enabled | ||
| name: yeti | ||
| repository: https://google.github.io/osdfir-infrastructure/ | ||
| version: 0.1.0 |
There was a problem hiding this comment.
This is the version number of the chart, not Yeti, right?
There was a problem hiding this comment.
Yep exactly, although let me bump that to 1.0.0 (going to do that with the rest of the charts as well) given that we have adequate testing in place now
There was a problem hiding this comment.
Actually going to do in separate PR along with the other charts
Co-authored-by: Thomas Chopitea <[email protected]> Signed-off-by: Wajih Yassine <[email protected]>
wajihyassine
commented
Jan 12, 2024
| - condition: global.yeti.enabled | ||
| name: yeti | ||
| repository: https://google.github.io/osdfir-infrastructure/ | ||
| version: 0.1.0 |
There was a problem hiding this comment.
Yep exactly, although let me bump that to 1.0.0 (going to do that with the rest of the charts as well) given that we have adequate testing in place now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusingreadme-generator-for-helm