Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

charts/timesketch Lock tag by release version, simplify ingress for non GKE setups, remove roll and config override, allow multiple instances to run, README updates #168

Merged
merged 7 commits into from
Sep 26, 2024
Merged

charts/timesketch Lock tag by release version, simplify ingress for non GKE setups, remove roll and config override, allow multiple instances to run, README updates #168

merged 7 commits into from
Sep 26, 2024

Conversation

wajihyassine
Copy link
Member

@wajihyassine wajihyassine commented Sep 23, 2024 •
edited
Loading

Description of the change

  • Allows for multiple instances of Timesketch to run on the same cluster with a different release name
  • Remove roll logic to only update Timesketch pods when something changed
  • Remove config.override given existing.configMap can now be provided
  • Generalize Ingress to be more compatible in other environments
  • README updates adding instructions on how to update the image tag, upgrading helm chart, moving sections around
  • Lock tag by release version

Applicable issues

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Newly added variables are documented in the values.yaml
  • Title of the pull request is descriptive

@wajihyassine wajihyassine changed the title charts/timesketch Make ingress more generalized for other setups, remove roll and config override, README updates charts/timesketch Make ingress more generalized for other setups, remove roll and config override, README updates, allow multiple instances of Timesketch Sep 23, 2024
@wajihyassine wajihyassine self-assigned this Sep 23, 2024
@wajihyassine wajihyassine changed the title charts/timesketch Make ingress more generalized for other setups, remove roll and config override, README updates, allow multiple instances of Timesketch charts/timesketch Lock tag by release version, Make ingress more generalized for other setups, remove roll and config override, README updates, allow multiple instances of Timesketch Sep 24, 2024
@wajihyassine wajihyassine changed the title charts/timesketch Lock tag by release version, Make ingress more generalized for other setups, remove roll and config override, README updates, allow multiple instances of Timesketch charts/timesketch Lock tag by release version, simplify ingress for non GKE setups, remove roll and config override, allow multiple instances to run, README updates Sep 24, 2024
@wajihyassine wajihyassine marked this pull request as ready for review September 24, 2024 23:08
@wajihyassine wajihyassine requested a review from jkppr September 24, 2024 23:08
jkppr
jkppr approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@jkppr jkppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wajihyassine wajihyassine merged commit 11f18a3 into main Sep 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkppr jkppr jkppr approved these changes

Assignees

@wajihyassine wajihyassine

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Quality of life updates to OSDFIR Infrastructure charts
2 participants
@wajihyassine @jkppr