Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

charts/turbinia Update README with config updates and remove release Turbinia config logic pull in init-container #166

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

wajihyassine
Copy link
Member

@wajihyassine wajihyassine commented Sep 13, 2024

…config

Description of the change

Updates the Turbinia README with the various methods for updating the Turbinia config file including an existing configmap. Removes the logic to grab latest Turbinia config release due to Github rate limiting issues.

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Newly added variables are documented in the values.yaml
  • Title of the pull request is descriptive

@wajihyassine wajihyassine self-assigned this Sep 13, 2024
@wajihyassine wajihyassine marked this pull request as ready for review September 13, 2024 21:28
@hacktobeer hacktobeer self-requested a review September 14, 2024 14:32
Copy link
Collaborator

@hacktobeer hacktobeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, super thanks for documenting how config updates can be done in a running cluster!

@wajihyassine wajihyassine merged commit 639a9c4 into main Sep 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github rate limit hit pulling Turbinia releases information
2 participants