Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README steps to upgrade Timesketch DB #162

Merged
merged 8 commits into from
Aug 30, 2024
Merged

Conversation

jkppr
Copy link
Collaborator

@jkppr jkppr commented Aug 28, 2024

This PR adds a section in the Timesketch charts readme file explaining how to perform Database upgrades for the kubernetes deployment when required by the new Timesketch release.

@jkppr jkppr added the documentation Improvements or additions to documentation label Aug 28, 2024
@jkppr jkppr requested a review from wajihyassine August 28, 2024 09:31
@jkppr jkppr self-assigned this Aug 28, 2024
@jkppr
Copy link
Collaborator Author

jkppr commented Aug 28, 2024

Failing test:

Deleting outdated charts
Linting chart "timesketch => (version: \"1.0.5\", path: \"charts/timesketch\")"
Checking chart "timesketch => (version: \"1.0.5\", path: \"charts/timesketch\")" for a version bump...
Old chart version: 1.0.5
Error: failed linting charts: failed processing charts
New chart version: 1.0.5

@wajihyassine Given I only updated documentation and not the charts, should this still be bumped?

jkppr added 3 commits August 28, 2024 17:33
Signed-off-by: Janosch <[email protected]>
Signed-off-by: Janosch <[email protected]>
Signed-off-by: Janosch <[email protected]>
Copy link
Member

@wajihyassine wajihyassine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the changes!

@wajihyassine
Copy link
Member

Failing test:

Deleting outdated charts
Linting chart "timesketch => (version: \"1.0.5\", path: \"charts/timesketch\")"
Checking chart "timesketch => (version: \"1.0.5\", path: \"charts/timesketch\")" for a version bump...
Old chart version: 1.0.5
Error: failed linting charts: failed processing charts
New chart version: 1.0.5

@wajihyassine Given I only updated documentation and not the charts, should this still be bumped?

So I thought that was the case, but issue template needs to be updated it doesn't look like the chart-testing knows how to differentiate certain files while including it into the packaged chart still helm/chart-testing#530. Need to look into either updating the issue template or finding a way to update exclude *.md files

For this case can you bump the version number and then run helm dependency update and then should be good to merge.

@jkppr jkppr merged commit 9a85fd3 into google:main Aug 30, 2024
3 checks passed
@jkppr jkppr deleted the ts-add-db-upgrade branch August 30, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants