-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix up spelling/typos in codebase #807
Conversation
Ran the automated tool [codespell](https://github.com/codespell-project/codespell) over the codebase to fix up minor typos/spelling mistakes. I've left `units.py` alone as it's autogenerated, but it would be good to tidy up the mistakes in the source data at some point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for the fixes!
@@ -154,7 +154,7 @@ def __init__(self, destination, transport): | |||
self._transport = transport | |||
|
|||
def is_closed(self): | |||
"""Return True iff the stream is closed.""" | |||
"""Return True if the stream is closed.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was intentional, but in my opinion “if” is sufficient.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I wasn't sure especially as the number of 'f's just kept going up in subsequent comments. :-)
@@ -176,7 +176,7 @@ fits in based on what it does. | |||
| | |||
| Generic utility functions and miscellaneous tools. | |||
| The contents of this submodule should be general enough to be | |||
| useable outside of OpenHTF, meaning it should not be dependent | |||
| usable outside of OpenHTF, meaning it should not be dependent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update mfg_event.proto fixed typos and closed open brackets (google#807) fixed typos and closed open brackets (google#807)
Ran the automated tool codespell
over the codebase to fix up minor typos/spelling mistakes.
I've left
units.py
alone as it's autogenerated, but it would be goodto tidy up the mistakes in the source data at some point.
There should be no functional changes as part of this commit.
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)