Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up spelling/typos in codebase #807

Merged
merged 1 commit into from
Jul 9, 2018
Merged

Fix up spelling/typos in codebase #807

merged 1 commit into from
Jul 9, 2018

Conversation

sam-bristow
Copy link
Contributor

@sam-bristow sam-bristow commented Jul 2, 2018

Ran the automated tool codespell
over the codebase to fix up minor typos/spelling mistakes.

I've left units.py alone as it's autogenerated, but it would be good
to tidy up the mistakes in the source data at some point.

There should be no functional changes as part of this commit.


This change is Reviewable

Ran the automated tool [codespell](https://github.com/codespell-project/codespell)
over the codebase to fix up minor typos/spelling mistakes.

I've left `units.py` alone as it's autogenerated, but it would be good
to tidy up the mistakes in the source data at some point.
Copy link
Contributor

@Kenadia Kenadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the fixes!

@@ -154,7 +154,7 @@ def __init__(self, destination, transport):
self._transport = transport

def is_closed(self):
"""Return True iff the stream is closed."""
"""Return True if the stream is closed."""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was intentional, but in my opinion “if” is sufficient.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I wasn't sure especially as the number of 'f's just kept going up in subsequent comments. :-)

@@ -176,7 +176,7 @@ fits in based on what it does.
|
| Generic utility functions and miscellaneous tools.
| The contents of this submodule should be general enough to be
| useable outside of OpenHTF, meaning it should not be dependent
| usable outside of OpenHTF, meaning it should not be dependent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kenadia Kenadia merged commit 696a3be into google:master Jul 9, 2018
iHarshit15 added a commit to iHarshit15/openhtf that referenced this pull request Dec 14, 2023
iHarshit15 added a commit to iHarshit15/openhtf that referenced this pull request Dec 14, 2023
Update mfg_event.proto

fixed typos and closed open brackets (google#807)
fixed typos and closed open brackets (google#807)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants