Refactor console domain actions to exist in separate files #2638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbrodman
force-pushed
the
refactorDomain
branch
from
b06a0f7 to
935bc1b
Compare
gbrodman
force-pushed
the
refactorDomain
branch
from
935bc1b to
e56d8a6
Compare
|
friendly ping |
ptkach
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @gbrodman)
This means that we're not storing everything in one file, otherwise it quickly becomes unwieldy
gbrodman
force-pushed
the
refactorDomain
branch
from
e56d8a6 to
e5f843d
Compare
ptkach
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that we're not storing everything in one file, otherwise it quickly becomes unwieldy
This change is