Update Gradle wrapper to 5.6 #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like there are some issues with the Gradle upgrade and the shadow jar plugin that we use to build the Nomulus tool. |
jianglai
force-pushed
the
gradle-version
branch
from
1aa98f7 to
6b318fd
Compare
|
This is due to GradleUp/shadow#508. I'll push an update soon. |
gbrodman
reviewed
Aug 24, 2019
| @@ -1,3 +1,4 @@ | |||
| org.gradle.jvmargs=-Xmx1024m | |||
There was a problem hiding this comment.
Isn't this the default? Is specifying it necessary?
There was a problem hiding this comment.
Somehow it was giving me OOM error when I didn't specify this...
There was a problem hiding this comment.
I was apparently wrong, or the posts online I found were wrong. Default is 512 MB apparently
https://docs.gradle.org/current/userguide/build_environment.html#sec:configuring_jvm_memory
gbrodman
approved these changes
Aug 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is