Use vswhere to find Visual C++ in Windows
#1057
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request. While I agree that
It’s highly unlikely that we can support any newer version of Visual Studio as long as we keep using GYP, which is no longer actively developed. |
yukawa
reviewed
Sep 6, 2024
|
|
||
| def find_vswhere() -> Optional[pathlib.Path]: | ||
| path = pathlib.Path(r'C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe') |
There was a problem hiding this comment.
Let’s use %ProgramFiles(x86)%.
yukawa
reviewed
Sep 6, 2024
| return pathlib.Path(first) | ||
|
|
||
| def get_display_name_from_vswhere(vswhere_path: pathlib.Path) -> Optional[str]: | ||
| result = subprocess.run([str(vswhere_path), '-property', 'displayName', '-utf8'], stdout=subprocess.PIPE) |
There was a problem hiding this comment.
Unless it’s absolutely necessary, I prefer to set shell=False to avoid any unnecessary complexities coming from cmd.exe.
|
hiroyuki-komatsu
pushed a commit
that referenced
this pull request
Oct 4, 2024
Unlike GYP build, we cannot simply pass '--vcvarsall_path' in Bazel build for Windows (#948). To support environment where Visual C++ is installed in a non standard directory, 'vs_util.py' starts using 'vswhere.exe' [1] with this commit. See also #1057. [1]: https://github.com/microsoft/vswhere PiperOrigin-RevId: 682300183
yukawa
added a commit
to yukawa/mozc
that referenced
this pull request
Jan 8, 2025
This is a follow up commit to my previous commit [1], which started using 'vswhere.exe' to locate 'vcvarsall.bat' as discussed in google#1057. One thing I overlooked is that 'vswhere.exe' might have returned an empty result even when the exitcode is ERROR_SUCCESS. With this commit such a case will be gracefully handled. This is also a preparation to support ARM64 build on Windows (google#1130). [1]: ace3145
yukawa
added a commit
to yukawa/mozc
that referenced
this pull request
Jan 8, 2025
This is a follow up commit to my previous commit [1], which started using 'vswhere.exe' to locate 'vcvarsall.bat' as discussed in google#1057. One thing I overlooked is that 'vswhere.exe' could return an empty result even when the exitcode is ERROR_SUCCESS. With this commit such a case will be gracefully handled. This is also a preparation to support ARM64 build on Windows (google#1130). [1]: ace3145
yukawa
added a commit
to yukawa/mozc
that referenced
this pull request
Jan 8, 2025
This is a follow up commit to my previous commit [1], which started using 'vswhere.exe' to locate 'vcvarsall.bat' as discussed in google#1057. One thing I overlooked is that 'vswhere.exe' could return an empty result even when the exitcode is ERROR_SUCCESS. With this commit such a case will be gracefully handled. This is also a preparation to support ARM64 build on Windows (google#1130). [1]: ace3145
hiroyuki-komatsu
pushed a commit
that referenced
this pull request
Jan 9, 2025
This is a follow up commit to my previous commit [1], which started using 'vswhere.exe' to locate 'vcvarsall.bat' as discussed in #1057. One thing I overlooked is that 'vswhere.exe' could return an empty result even when the exitcode is ERROR_SUCCESS. With this commit such a case will be gracefully handled. This is also a preparation to support ARM64 build on Windows (#1130). [1]: ace3145 PiperOrigin-RevId: 713563231
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A clear and concise description of this pull request.
Visual Studio provides
vswhereto make it easier to find the path of a file provided by Visual Studio.We should use it to find
vcvarsall.batinstaed of designating its path directly.Issue IDs
Issue and/or discussion IDs related to this pull request.
Steps to test new behaviors (if any)
A clear and concise description about how to verify new behaviors (if any).
cd srcpython ./build_mozc.pyAdditional context
Add any other context about the pull request here.
We won't need to make extra changes for newer Visual Studio in the future anymore.