Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hard to read texts on the AboutDialog when a dark desktop theme is selected #897

Closed
yukawa opened this issue Mar 14, 2024 · 0 comments · Fixed by #898
Closed

Hard to read texts on the AboutDialog when a dark desktop theme is selected #897

yukawa opened this issue Mar 14, 2024 · 0 comments · Fixed by #898

Comments

@yukawa
Copy link
Collaborator

yukawa commented Mar 14, 2024

Description

AboutDialog's background colors are hard-coded with an assumption that the text is rendered with a dark color, which is, however, not true when a dark desktop theme is selected.

Steps to reproduce

Steps to reproduce the behavior:

  1. Build and install Mozc
  2. "%ProgramFiles(x86)%\Mozc\mozc_tool.exe" --mode=about_dialog

Expected behavior

You can clearly see the contents on the about dialog.

Actual behavior

You can clearly see the contents on the about dialog.

Screenshots

On Windows 11 23H2

AboutDialog-win

On macOS 14.4

AboutDialog-mac

Version or commit-id

ce08bae

Environment

  • OS: Windows 11 23H2
  • OS: macOS 14.4
@yukawa yukawa mentioned this issue Mar 14, 2024
Closed
@siketyan siketyan mentioned this issue Mar 14, 2024
Merged
hiroyuki-komatsu added a commit that referenced this issue Apr 6, 2024
@hiroyuki-komatsu
Update MINOR to 30 and BUILD_OSS to 5432
d625fb8 
Features
* Supported the conversion from "なう" to date/time (i.e. 2024/12/31 23:59)
* Supported loading user dictionary files exported from Gboard
* Fixed voiced Katakana conversion from ゑ (ヸ → ヹ)
* Improved the about dialog with the dark mode (#897)
* Linux: Improved the candidate UI with HiDPI displays (#823)

Build
* Updated the Protobuf version: v25.0 → v26.1
* Updated the Abseil version: 20230802.1 → 20240116.1
* Updated the Qt version: 6.6.2 → 6.7.0

Code
* Performed code refactoring

PiperOrigin-RevId: 622060710
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(about_dialog): Always use black color for window texts siketyan/mozc
1 participant
@yukawa