Remove require_selection from autocomplete #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forgot to remove this when creating the autocomplete component initially. The require_selection property overall is not too helpful for Mesop. The require_selection can be implemented in Mesop by just using the AutocompleteSelectionChangeEvent when populating valid option values.
|
It's a pretty new component, but may be worth a quick check within Google to see if this parameter is being used since removing it is technically a breaking change (worst case, I'd just call it out the next time you sync into google3). Looking at GitHub, I don't think this parameter is used: https://github.com/search?q=%22+me.autocomplete%28%22+language%3APython&type=code |
wwwillchen
approved these changes
Sep 12, 2024
|
Ah yeah, good point. Yeah, I'll check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to remove this when creating the autocomplete component initially.
The require_selection property overall is not too helpful for Mesop. The require_selection can be implemented in Mesop by just using the AutocompleteSelectionChangeEvent when populating valid option values.