Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream generate response to UI #837

Merged
merged 5 commits into from
Aug 25, 2024
Merged

Conversation

wwwillchen
Copy link
Collaborator

@wwwillchen wwwillchen commented Aug 25, 2024

  • Streams token to the UI while generating code for UI - this makes the UX a bit more pleasant since you can start reviewing the code right away.
  • Switches the final dialog for approving the code changes to use unified diff view to match the intermediate UI a bit more (there's a slightly jarring scroll reset, but it seems unavoidable given that even if we reused the same dialog, it might not be correct to use the current scroll position).

Stream generate response to UI

strm
@wwwillchen wwwillchen merged commit ca3a947 into google:main Aug 25, 2024
2 checks passed
@wwwillchen wwwillchen deleted the stream_response branch August 25, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant