Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show an error dialog if web component is not registered #754

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

wwwillchen
Copy link
Collaborator

@wwwillchen wwwillchen commented Aug 7, 2024

Fixes #729.

image

Only displays the dialog in debug mode. In prod mode, logs console error.

@wwwillchen wwwillchen requested a review from richard-to August 7, 2024 06:53
@wwwillchen wwwillchen merged commit df9edb0 into google:main Aug 7, 2024
3 checks passed
@wwwillchen wwwillchen deleted the wc_typo branch August 7, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If web component name is registered differently in js file from py file, no error is thrown
2 participants