Add SQL state session backend. #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This state session backend uses SQL Alchemy to support different SQL databases. I tested using SQlite3 and PostgreSQL. Both seemed to work fine. One slight workflow issue is that for non-SQLite3 databases, people will need to manually run a script to create the database table used for storing state sessions. The commands are mentioned in the config.md file. That's not the most user friendly approach. So probably need a better way to approach it. But I think for the initial version of this backend, it should be OK, especially considering we don't know how many people will actually use it.
wwwillchen
requested changes
Jul 11, 2024
wwwillchen
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This state session backend uses SQL Alchemy to support different SQL databases.
I tested using SQlite3 and PostgreSQL. Both seemed to work fine.
One slight workflow issue is that for non-SQLite3 databases, people will need to manually run a script to create the database table used for storing state sessions. The commands are mentioned in the config.md file. That's not the most user friendly approach. So probably need a better way to approach it. But I think for the initial version of this backend, it should be OK, especially considering we don't know how many people will actually use it.
Ref: #556