-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds svg_icon fixes #529 #567
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing!
Could you create an "svg_icon_app.py" to demonstrate how to use this web component? e.g. we do this for our other web component examples: https://github.com/google/mesop/blob/main/mesop/examples/web_component/quickstart/counter_component_app.py
And then you can import it here: https://github.com/google/mesop/blob/main/mesop/examples/web_component/__init__.py and then this will load the app into the main Mesop example app, e.g. when you run ./scripts/cli.sh
I think there's some formatting issues which could be solved by installing our pre-commit hooks: https://google.github.io/mesop/internal/development/#commit-hooks |
Thanks for contributing! |
Adds an example of a web component
svg_icon
that takes an SVG XML and renders it