Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add steps to install playwright in .devcontainer.json #404

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

richard-to
Copy link
Collaborator

Ref: #397

Copy link
Collaborator

@wwwillchen wwwillchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - this seems a little painful to maintain if we upgrade playwright (but that's pretty rare I think).

Future idea: I don't know if this makes sense, but could we run Playwright from a separate Docker container and have it connect to the local dev container? This way we could use Playwright's included Docker container image https://playwright.dev/docs/docker

Dockerfile Outdated Show resolved Hide resolved
@richard-to richard-to force-pushed the install-playwright branch from 40a49d3 to 5b4149f Compare June 10, 2024 17:37
@richard-to
Copy link
Collaborator Author

LGTM - this seems a little painful to maintain if we upgrade playwright (but that's pretty rare I think).

Future idea: I don't know if this makes sense, but could we run Playwright from a separate Docker container and have it connect to the local dev container? This way we could use Playwright's included Docker container image https://playwright.dev/docs/docker

Yeah, I agree I was concerned about that as well. Unfortunately for some reason in Codespaces, the post set up command that gets run does not use root. And sudo doesn't work.

Weirdly when I do this locally, the post set up command seems to run as root, so for local dev container, I could just run the command.

Hmm, yeah using the separate docker container image seems like an interesting idea to look into. It's fairly easy to create add container in the Docker Compose configuration. And we should be able to access the main container from the playwright container. It'd need a way to start up the server and some other things. So I think it mostly amounts to configuring things correctly for this use case.

@richard-to richard-to merged commit 1b57454 into google:main Jun 10, 2024
3 checks passed
wwwillchen pushed a commit to wwwillchen/mesop that referenced this pull request Jun 14, 2024
@richard-to richard-to deleted the install-playwright branch July 2, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants