Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a more visual home page for demo gallery #374

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

wwwillchen
Copy link
Collaborator

@wwwillchen wwwillchen commented Jun 7, 2024

image

Fixes #366

Added instructions for re-generating screenshots in demo/README.md

@wwwillchen wwwillchen requested a review from richard-to June 7, 2024 22:39
@wwwillchen
Copy link
Collaborator Author

@richard-to ignoring the performance overhead (there's some ways to make it better), WDYT about the overall design of this as our demo home page?

@richard-to
Copy link
Collaborator

It's nice that someone can scroll through and view what the demos look like without clicking each one of them. So I think that's good.

Still doesn't fit in mobile even on an iphone pro max screen:

Screenshot 2024-06-07 at 3 49 02 PM

A few minor things. The rounded borders on the top edges of the cards look cut off. Would be nice if there was a bit more padding around some of the demos themselves. But it makes sense why there is no padding in the demos since we want to show the simplest code example for the components.

Copy link
Collaborator

@richard-to richard-to left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wwwillchen
Copy link
Collaborator Author

It's nice that someone can scroll through and view what the demos look like without clicking each one of them. So I think that's good.

Still doesn't fit in mobile even on an iphone pro max screen:

Screenshot 2024-06-07 at 3 49 02 PM A few minor things. The rounded borders on the top edges of the cards look cut off. Would be nice if there was a bit more padding around some of the demos themselves. But it makes sense why there is no padding in the demos since we want to show the simplest code example for the components.

Yeah, we need to use proper media query to hide the sidenav I think.

Re: borders, I noticed it too and yep, it's tough to make it look good vs. keeping the code minimal (although we might've gone too far with the minimalist code). I've noticed for example in angular material components, they will do some basic CSS styling just to make sure the example looks good, and oftentimes it's pretty helpful to copy those stylings as well.

@wwwillchen
Copy link
Collaborator Author

I've updated this to be mobile friendly both on the home page and the demo/embed page.

@wwwillchen wwwillchen merged commit 11d8cd8 into google:main Jun 10, 2024
3 checks passed
@wwwillchen wwwillchen deleted the demo_sshot branch June 10, 2024 08:07
wwwillchen added a commit to wwwillchen/mesop that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the demo gallery app responsive
2 participants