Fixes major memory leak in component renderer #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwwillchen
force-pushed
the
fix-mem-leak
branch
from
fa8e631 to
ebb081e
Compare
wwwillchen
changed the title
wwwillchen
changed the title
wwwillchen
changed the title
wwwillchen
force-pushed
the
fix-mem-leak
branch
from
8039eb9 to
7497fcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you navigate to the same pages over and over again, you can measure an significant increase in JS memory (heap snapshots). The main contributor was that we weren't cleaning up the embedded view refs.