Fix clearing query params when navigating #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-to
approved these changes
Nov 9, 2024
The problem was that previously we were doing me.query_params.clear() which issued a clear query param command which modified the browser history. By directly deleting the query params from context, we avoid issuing this command, and thus not modifying the query param in the browser history. |
Ah thanks for the explanation. That makes sense now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation had a flaw where it issued a command to clear the query params which resulted in replacing the browser history entry, which means that back navigations would not restore the original query params. (The e2e test case demonstrates this issue).