Add env var: MESOP_APP_BASE_PATH #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwwillchen
force-pushed
the
static-files-base
branch
from
0e76fa2 to
b3a20ff
Compare
richard-to
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds MESOP_APP_BASE_PATH as a new configuration via env var to support the use case where
os.getcwd()cannot be reliably used as the app base path. Specifically, if you want to build a pip package CLI app that runs Mesop, using the cwd isn't feasible because the app user can be running the CLI command from an arbitrary directory (and not the mesop app directory). I suspect this is a pretty niche use case so I don't think most people will need to use this.Note: the testing for this isn't that great (it's not trivial to cover the pip CLI use case with our current integration test infra), but it covers the static folder case.