Fix array proto types for select.ts (#1037)

google · Oct 16, 2024 · 75edeb8 · 75edeb8
1 parent 4a48fec
commit 75edeb8
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/mesop/components/select/select.ts b/mesop/components/select/select.ts
@@ -25,8 +25,8 @@ export class SelectComponent {
   @Input() style!: Style;
   private _config!: SelectType;
 
-  selectedOptions: string[] = [];
-  private initialSelectOptions: string[] = [];
+  selectedOptions: readonly string[] = [];
+  private initialSelectOptions: readonly string[] = [];
 
   constructor(private readonly channel: Channel) {}
 
@@ -87,10 +87,10 @@ export class SelectComponent {
     return this.config().getAppearance() as 'fill' | 'outline';
   }
 
-  private _checkInitialValuesChanged(values: string[]): boolean {
+  private _checkInitialValuesChanged(values: readonly string[]): boolean {
     return (
-      JSON.stringify(this.initialSelectOptions.sort()) !==
-      JSON.stringify(values.sort())
+      JSON.stringify(this.initialSelectOptions.slice().sort()) !==
+      JSON.stringify(values.slice().sort())
     );
   }
 }